CurtHagenlocher commented on PR #503: URL: https://github.com/apache/arrow-dotnet/pull/503#issuecomment-6896148449
On the "previously missed" item in the latest review (the inner handler's `release` after a failed schema import, `proxy.c`): that one is real, and it's a bug in arrow-go v18.8.0, now filed as apache/arrow-go#1573. When `asyncStreamOnSchema` fails, it frees its handler state but leaves `release` installed. `asyncStreamRelease` then panics with `runtime/cgo: misuse of an invalid Handle`. Fixed in 4848e65: - The proxy now records when arrow-go's `on_schema` failed, and in that case doesn't forward `release` to arrow-go, since arrow-go has already cleaned up. - A new test, `GoConsumerRejectingSchemaReleasesCleanly`, acts as the producer, sends a schema arrow-go can't import, then calls `release` as the spec requires. Before the fix it crashed the test host every time; with the fix, all of the async tests passed 20 of 20 runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
