CurtHagenlocher commented on PR #503:
URL: https://github.com/apache/arrow-dotnet/pull/503#issuecomment-6896548513

   On the latest review's summary (the proxy's cancel path deadlocking if a 
producer calls `release` synchronously): no behavior change, now documented in 
2693c2e.
   
   It's true of the proxy in general. `proxy_request` and `proxy_cancel` hold a 
non-reentrant spinlock while calling the real producer, and `outer_release` 
takes the same lock, so a producer that called `release` from inside `request` 
or `cancel` would spin forever.
   
   It can't happen with this proxy, though. The proxy is test-only, and the 
only producer it forwards to is Apache.Arrow's. That producer's `request` and 
`cancel` only update state: they start the produce loop with `Task.Run`, and 
cancellation of a pending source read also runs on the thread pool. So 
`release` always comes from another thread, and `outer_release` just waits 
briefly for the forwarded call to return. A comment in `proxy.c` now states 
that assumption.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to