CurtHagenlocher commented on PR #503:
URL: https://github.com/apache/arrow-dotnet/pull/503#issuecomment-6896419664

   On the latest review's summary (an export failure possibly suppressing 
`on_error`): no change to the producer, but it pointed at a real gap in the 
consumer, fixed in 684d1df.
   
   **Producer, unchanged.** When exporting a batch fails inside `extract_data`, 
the producer returns the error and reports it through `on_error` if it still 
can. It drops the report once the stream is finishing or released, because 
nothing may follow `release`, and an `on_error` after end-of-stream would 
contradict the end of the stream. Consumers may extract that late (arrow-go 
does), so `on_error` can't be guaranteed for a failed extract. That comes from 
the spec. There's now a comment explaining this in `ReportError`.
   
   **Consumer, fixed.** On a failed `extract_data`, the consumer used to drop 
the batch and wait for the producer's `on_error`. If none came, the stream 
ended normally with that batch missing. It now records the failure as a stream 
error, with the error code, and returns non-zero so the producer stops. The new 
`FailedExtractIsReportedWithoutOnError` test uses a fake producer that fails 
`extract_data` and releases without `on_error`. It fails with the old behavior 
and passes with the fix.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to