alamb commented on a change in pull request #406:
URL: https://github.com/apache/arrow-rs/pull/406#discussion_r645843369
##########
File path: arrow/src/array/array_binary.rs
##########
@@ -728,8 +730,11 @@ impl From<ArrayData> for DecimalArray {
impl fmt::Debug for DecimalArray {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
write!(f, "DecimalArray<{}, {}>\n[\n", self.precision, self.scale)?;
+ let point_index = 10_i128.pow(self.scale as u32);
Review comment:
This looks fine to me -- though a slightly different approach for
displaying Decimal values is taken here:
https://github.com/apache/arrow-rs/blob/master/arrow/src/util/display.rs#L195-L207
I wonder if there is some way to use the same code in all places we need to
format Decimals?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
