alamb commented on a change in pull request #406:
URL: https://github.com/apache/arrow-rs/pull/406#discussion_r646117403
##########
File path: arrow/benches/csv_writer.rs
##########
@@ -28,14 +28,14 @@ use arrow::record_batch::RecordBatch;
use std::fs::File;
use std::sync::Arc;
-fn record_batches_to_csv() {
+fn criterion_benchmark(c: &mut Criterion) {
Review comment:
> Since it's somewhat connected to the CSVWriter changes and this code
is not user-facing just a utility we fire manually I didn't open a new PR.
Should I separate the change? For me it was like a docs change, let me know if
we treat those differently.
I think it is fine to put in this PR too -- I just didn't know if the
changes were included accidentally or not and wanted to check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
