alippai commented on a change in pull request #406:
URL: https://github.com/apache/arrow-rs/pull/406#discussion_r646117049
##########
File path: arrow/benches/csv_writer.rs
##########
@@ -28,14 +28,14 @@ use arrow::record_batch::RecordBatch;
use std::fs::File;
use std::sync::Arc;
-fn record_batches_to_csv() {
+fn criterion_benchmark(c: &mut Criterion) {
Review comment:
I quickly checked the `String` vs `div_rem` performance for serializing
Decimal data (there was no diff) and noticed that the related benchmark doesn't
really track CSV serialization performance. Instead it was heavy on
constructing the data and creating the file which I moved out of the hot path
of the benchmark to a setup phase.
Since it's somewhat connected to the CSVWriter changes and this code is not
user-facing just a utility we fire manually I didn't open a new PR. Should I
separate the change? For me it was like a docs change, let me know if we treat
those differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
