jorgecarleitao commented on a change in pull request #474:
URL: https://github.com/apache/arrow-rs/pull/474#discussion_r656102251
##########
File path: arrow/src/array/array_list.rs
##########
@@ -50,6 +50,9 @@ impl OffsetSizeTrait for i64 {
}
}
+/// Generic struct for a primitive Array
+///
+/// Instead of using `GenericListArray` directly, consider using `ListArray`
or `LargeListArray`
Review comment:
fwiw, I do not think this recommendation is fair. `GenericListArray`
allows to write code generic over the `Offset`, which is more generic than only
supporting `ListArray` or `LArgeListArray`.
The same applies for `Utf8Array<T>`, `PrimitiveArray<T>`, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
