novemberkilo commented on a change in pull request #474:
URL: https://github.com/apache/arrow-rs/pull/474#discussion_r656112998



##########
File path: arrow/src/array/array_list.rs
##########
@@ -50,6 +50,9 @@ impl OffsetSizeTrait for i64 {
     }
 }
 
+/// Generic struct for a primitive Array
+///
+/// Instead of using `GenericListArray` directly, consider using `ListArray` 
or `LargeListArray`

Review comment:
       Thanks @jorgecarleitao - I'm a little confused though. My initial commit 
attempted to show an example of this 
https://github.com/apache/arrow-rs/pull/474/commits/4c5b2b45ceabfdc0564a46eed15bf937333dbb91
 which admittedly was the equivalent of the example for `ListArray` 
   
   Would you perhaps suggest different wording for this comment, or perhaps 
could you point me in the direction of a better example that we could use for 
`GenericListArray` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to