novemberkilo commented on a change in pull request #474:
URL: https://github.com/apache/arrow-rs/pull/474#discussion_r656129560
##########
File path: arrow/src/array/array_list.rs
##########
@@ -50,6 +50,9 @@ impl OffsetSizeTrait for i64 {
}
}
+/// Generic struct for a primitive Array
+///
+/// Instead of using `GenericListArray` directly, consider using `ListArray`
or `LargeListArray`
Review comment:
Thanks - fwiw I was trying to tackle the specific problem of showing by
an example, how to construct a `GenericListArray`
Per https://github.com/apache/arrow-rs/pull/474#pullrequestreview-687894203
I removed the example for `GenericListArray` in favour of examples for
`ListArray` and `LargeListArray.` The intent was not to suggest that using
`ListArray` is better or worse than using `GenericListArray`
In any case, also removing the comment will result in no documentation or
examples for `GenericListArray`
Is that the final state we want? Or should we have some documentation or
hints for usage for `GenericListArray`
Hope that all makes sense. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
