rok commented on a change in pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#discussion_r661477000
##########
File path: r/src/compute.cpp
##########
@@ -264,6 +264,12 @@ std::shared_ptr<arrow::compute::FunctionOptions>
make_compute_options(
max_replacements);
}
+ if (func_name == "day_of_week") {
+ using Options = arrow::compute::TemporalComponentExtractionOptions;
+ return
std::make_shared<Options>(cpp11::as_cpp<bool>(options["one_based_numbering"]),
Review comment:
Got it, you mean like this?
```C++
if (func_name == "day_of_week") {
using Options = arrow::compute::TemporalComponentExtractionOptions;
bool one_based_numbering = true;
return std::make_shared<Options>(one_based_numbering,
cpp11::as_cpp<uint32_t>(options["week_start"]));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
