pitrou commented on a change in pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#discussion_r661562096
##########
File path: r/R/dplyr-functions.R
##########
@@ -526,14 +526,6 @@ nse_funcs$second <- function(x) {
Expression$create("add", Expression$create("second", x),
Expression$create("subsecond", x))
}
-# After ARROW-13054 is completed, we can refactor this for simplicity
Review comment:
That assumes you're using the same options class for all these kernels,
which seems a bit weird to me (why would the `year` kernel take unrelated
options pertaining to day-of-week numbering?).
cc @bkietz for a second opinion on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
