thisisnic commented on a change in pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#discussion_r661563732
##########
File path: r/src/compute.cpp
##########
@@ -264,6 +264,12 @@ std::shared_ptr<arrow::compute::FunctionOptions>
make_compute_options(
max_replacements);
}
+ if (func_name == "day_of_week") {
+ using Options = arrow::compute::TemporalComponentExtractionOptions;
+ return
std::make_shared<Options>(cpp11::as_cpp<bool>(options["one_based_numbering"]),
Review comment:
I think it'd be very uncommon or never used at all, and even if someone
wanted to use it, it'd be easy for them just to deduct 1 from whatever value
they get, so I don't think it matters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
