lidavidm commented on a change in pull request #10511:
URL: https://github.com/apache/arrow/pull/10511#discussion_r661556675
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -188,23 +218,21 @@ enum CompareOperator : int8_t {
LESS_EQUAL,
};
-struct CompareOptions : public FunctionOptions {
- explicit CompareOptions(CompareOperator op) : op(op) {}
-
+class ARROW_EXPORT CompareOptions : public FunctionOptions {
+ public:
+ explicit CompareOptions(CompareOperator op);
Review comment:
Filed ARROW-13219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
