Jimexist commented on a change in pull request #687:
URL: https://github.com/apache/arrow-datafusion/pull/687#discussion_r664547321
##########
File path: datafusion/src/physical_plan/type_coercion.rs
##########
@@ -131,7 +131,10 @@ fn get_valid_types(
Signature::OneOf(types) => {
let mut r = vec![];
for s in types {
- r.extend(get_valid_types(s, current_types)?);
+ if let Ok(valid_types) = get_valid_types(s, current_types) {
Review comment:
no you were totally correct in that the original code didn't work. i
wasn't seeing this the first round.
i was thinking that you'd need to remove the commented out line below. also
do you mind adding a unit test for this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
