Jimexist commented on a change in pull request #687:
URL: https://github.com/apache/arrow-datafusion/pull/687#discussion_r665065785
##########
File path: datafusion/src/physical_plan/expressions/lead_lag.rs
##########
@@ -98,20 +105,58 @@ impl BuiltInWindowFunctionExpr for WindowShift {
Ok(Box::new(WindowShiftEvaluator {
shift_offset: self.shift_offset,
values,
+ default_value: self.default_value.clone(),
}))
}
}
pub(crate) struct WindowShiftEvaluator {
shift_offset: i64,
values: Vec<ArrayRef>,
+ default_value: Option<ScalarValue>,
+}
+
+fn shift_with_default_value(
Review comment:
you can add a comment of todo to push this upstream to arrow-rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
