jgoday commented on pull request #687: URL: https://github.com/apache/arrow-datafusion/pull/687#issuecomment-874944740
> this change looks generally okay, thanks for the effort! > > I would suggest: replacing branching with one call and also add a case in the integration test folder, esp.: > > 1. out of bounds shift offset, > > 2. negative bounds > > 3. default value being null Thank you @Jimexist. I have followed your advices and changed the type_coercion::get_valid_types to use filter_map and switch the two conditional branches to one single call to shift_with_default_value. I will try to look the integration tests later today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
