jgoday edited a comment on pull request #687: URL: https://github.com/apache/arrow-datafusion/pull/687#issuecomment-876968746
> if the first example works then it's fine. the second example might fail because of different reasons not related to this change. Two more questions/doubts ? * Would it be better to have a different sql for each case (lead/lag out of bounds/negative/default being null) or is it ok to test all combinations in a single sql? * Would it be more appropriate to squash into a single commit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
