edponce edited a comment on pull request #10727: URL: https://github.com/apache/arrow/pull/10727#issuecomment-880964640
*Food for thought:* Tests fail for `std::numeric_limits<Int64/Uint64>::min/max()` due to an invalid range when a `Scalar[Int64/Uint64]` input is checked against a `Scalar[Float64]` output. This failure also occurs for 32-bit floating-point values. This error is triggered by the [Arrow testing logic when casting integer-to-floating](https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/scalar_cast_numeric.cc#L195-L209) for comparing values in test assertions. This is normal behavior as not all integers have a floating-point representation. An example test is: ``` this->AssertUnaryOp(floor, this->MakeScalar(min), *arrow::MakeScalar(float64(), min)); this->AssertUnaryOp(floor, this->MakeScalar(max), *arrow::MakeScalar(float64(), max)); ``` and the error message is: ``` '_error_or_value11.status()' failed with Invalid: Integer value 18446744073709551615 not in range: 0 to 9007199254740992 ``` The meaning of these numbers is: ``` max(Uint64) = 18446744073709551615 max(2^53) = 9007199254740992 // mantissa of Float64 = 53 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
