jorisvandenbossche commented on a change in pull request #10727:
URL: https://github.com/apache/arrow/pull/10727#discussion_r671142050
##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##########
@@ -1567,6 +1588,24 @@ const FunctionDoc log1p_checked_doc{
"Use function \"log1p\" if you want non-positive values to return "
"-inf or NaN."),
{"x"}};
+
+const FunctionDoc floor_doc{
+ "Calculate the greatest integer in magnitude less than or equal to the "
+ "argument element-wise",
+ "",
Review comment:
```suggestion
"Round down to the nearest integer",
"Calculate the greatest integer in magnitude less than or equal to the "
"argument element-wise",
```
(that's how you explained it in the api_scalar.h doc comments, which I find
easier to understand as short summary of the function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
