jorisvandenbossche commented on a change in pull request #10727:
URL: https://github.com/apache/arrow/pull/10727#discussion_r671140639
##########
File path: cpp/src/arrow/compute/api_scalar.cc
##########
@@ -357,6 +357,9 @@ SCALAR_ARITHMETIC_BINARY(Power, "power", "power_checked")
SCALAR_ARITHMETIC_BINARY(ShiftLeft, "shift_left", "shift_left_checked")
SCALAR_ARITHMETIC_BINARY(ShiftRight, "shift_right", "shift_right_checked")
SCALAR_EAGER_BINARY(Atan2, "atan2")
+SCALAR_EAGER_UNARY(Floor, "floor")
+SCALAR_EAGER_UNARY(Ceiling, "ceiling")
Review comment:
```suggestion
SCALAR_EAGER_UNARY(Ceil, "ceil")
```
Is there a reason to have it "ceiling" instead of "ceil" (the C++ function
is ceil, as well as numpy. SQL seems to have both)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
