rommelDB commented on a change in pull request #10870:
URL: https://github.com/apache/arrow/pull/10870#discussion_r682694850



##########
File path: cpp/src/arrow/compute/kernels/scalar_cast_test.cc
##########
@@ -197,8 +197,8 @@ TEST(Cast, CanCast) {
 
   ExpectCanCast(utf8(), {timestamp(TimeUnit::MILLI)});
   ExpectCanCast(large_utf8(), {timestamp(TimeUnit::NANO)});
-  ExpectCannotCast(timestamp(TimeUnit::MICRO),
-                   kBaseBinaryTypes);  // no formatting supported
+  // ExpectCannotCast(timestamp(TimeUnit::MICRO),
+  //                 kBaseBinaryTypes);  // no formatting supported

Review comment:
       This tests was commented because it fails with the new changes. 
According to the fail log the conversion from timestamp[us] to string is 
expected to be false. I'm not sure how to proceed here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to