lidavidm commented on a change in pull request #10870:
URL: https://github.com/apache/arrow/pull/10870#discussion_r682852014
##########
File path: cpp/src/arrow/compute/kernels/scalar_cast_test.cc
##########
@@ -197,8 +197,8 @@ TEST(Cast, CanCast) {
ExpectCanCast(utf8(), {timestamp(TimeUnit::MILLI)});
ExpectCanCast(large_utf8(), {timestamp(TimeUnit::NANO)});
- ExpectCannotCast(timestamp(TimeUnit::MICRO),
- kBaseBinaryTypes); // no formatting supported
+ // ExpectCannotCast(timestamp(TimeUnit::MICRO),
+ // kBaseBinaryTypes); // no formatting supported
Review comment:
Because we have this above:
```cpp
for (const std::shared_ptr<DataType>& in_ty : TemporalTypes()) {
```
we're actually adding kernels not just for date32/date64, but also for
timestamp. So I think this can be changed to `ExpectCanCast`. And then we can
add test cases below for timestamp as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
