rommelDB commented on a change in pull request #10870:
URL: https://github.com/apache/arrow/pull/10870#discussion_r683586536
##########
File path: cpp/src/arrow/compute/kernels/scalar_cast_test.cc
##########
@@ -208,6 +207,14 @@ TEST(Cast, CanCast) {
ExpectCanCast(smallint(),
kNumericTypes); // any cast which is valid for storage is
supported
ExpectCannotCast(null(), {smallint()}); // FIXME missing common cast from
null
+
+ ExpectCanCast(date32(), {utf8(), large_utf8()});
+ ExpectCanCast(date64(), {utf8(), large_utf8()});
+ ExpectCanCast(timestamp(TimeUnit::NANO), {utf8(), large_utf8()});
+ ExpectCanCast(timestamp(TimeUnit::MICRO), {utf8(), large_utf8()});
+ ExpectCanCast(time32(TimeUnit::MILLI), {utf8(), large_utf8()});
+ ExpectCanCast(time64(TimeUnit::NANO), {utf8(), large_utf8()});
+ //ExpectCanCast(duration(TimeUnit::SECOND), {utf8(), large_utf8()}); //FIXME
Review comment:
Got it, I was confused by
https://github.com/apache/arrow/blob/af7588344c3fe59a69e02b6f5203e7b7ae06addf/cpp/src/arrow/compute/kernels/codegen_internal.h#L1262-L1263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
