nirandaperera commented on a change in pull request #10845:
URL: https://github.com/apache/arrow/pull/10845#discussion_r691393873
##########
File path: cpp/src/arrow/compute/exec/options.h
##########
@@ -111,5 +111,32 @@ class ARROW_EXPORT SinkNodeOptions : public
ExecNodeOptions {
std::function<Future<util::optional<ExecBatch>>()>* generator;
};
+enum JoinType {
Review comment:
I see.. yes, I can do that :-) Do we give preference to enum class over
plain enums?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
