nirandaperera commented on a change in pull request #10845:
URL: https://github.com/apache/arrow/pull/10845#discussion_r697877600
##########
File path: cpp/src/arrow/compute/exec/hash_join_node.cc
##########
@@ -39,7 +39,7 @@ Status ValidateJoinInputs(const std::shared_ptr<Schema>&
left_schema,
const std::shared_ptr<Schema>& right_schema,
const std::vector<int>& left_keys,
const std::vector<int>& right_keys) {
- if (left_keys.size() != right_keys.size()) {
+ if (left_keys.size() != right_keys.size() && left_keys.size() > 0) {
Review comment:
AFAIK I don't think it's valid. We'd need some indexer if no key columns
are specified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
