nirandaperera commented on a change in pull request #10845:
URL: https://github.com/apache/arrow/pull/10845#discussion_r700362614
##########
File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc
##########
@@ -2129,9 +2179,10 @@ Result<FieldVector> ResolveKernels(
Result<std::unique_ptr<Grouper>> Grouper::Make(const std::vector<ValueDescr>&
descrs,
ExecContext* ctx) {
- if (GrouperFastImpl::CanUse(descrs)) {
- return GrouperFastImpl::Make(descrs, ctx);
- }
+ // TODO(niranda) re-enable this!
+ // if (GrouperFastImpl::CanUse(descrs)) {
+ // return GrouperFastImpl::Make(descrs, ctx);
+ // }
Review comment:
Oh!!! I completely forgot about this TBH! :-( This needs to be added
before merging this PR. I was waiting for #10858 PR to be merged to add this
change!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
