novemberkilo opened a new pull request #922: URL: https://github.com/apache/arrow-datafusion/pull/922
ref #850 WIP - for purposes of discussion and feedback. @alamb I have done the simplest possible thing to get the branching code path that avoids the `is_valid` check. However, I'd appreciate some input on how best to proceed: - I'd like to figure out how best to refactor this code to reduce duplication. I'm not sure that the duplication is that bad in the first place. If we were to improve it, is this best done via an additional macro, or perhaps by changing the API of `eq_array` to take an additional parameter that signals whether the array has no-nulls. - How do I test `eq_array_no_nulls`? Should I look to follow the test for `eq_array`? Thanks much in advance for the guidance and input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
