novemberkilo commented on a change in pull request #922:
URL: https://github.com/apache/arrow-datafusion/pull/922#discussion_r699709923
##########
File path: datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -368,7 +376,10 @@ fn group_aggregate_batch(
group_values
.iter()
.zip(group_state.group_by_values.iter())
- .all(|(array, scalar)| scalar.eq_array(array, row))
+ .zip(null_information.iter())
+ .all(|((array, scalar), has_nulls)| {
+ scalar.eq_array(array, row, has_nulls)
+ })
Review comment:
Hi I don't understand the suggestion about hoisting `has_nulls` out of
the `all`
Would you be able to please sketch it out in pseudo code or similar?
I haven't used macros much and will go educate myself on how they work. Will
also get to profiling (although maybe not until the weekend).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
