alamb commented on a change in pull request #922:
URL: https://github.com/apache/arrow-datafusion/pull/922#discussion_r699389937
##########
File path: datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -368,7 +376,10 @@ fn group_aggregate_batch(
group_values
.iter()
.zip(group_state.group_by_values.iter())
- .all(|(array, scalar)| scalar.eq_array(array, row))
+ .zip(null_information.iter())
+ .all(|((array, scalar), has_nulls)| {
+ scalar.eq_array(array, row, has_nulls)
+ })
Review comment:
I think broadly speaking this is the pattern, though I am not sure how
well the compiler will be able to optimize given a has nulls parameter
`has_nulls` -- it might need to be hoisted out of this loop (the call to `all`
here)
Have you had a chance to try profiling?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
