nealrichardson commented on a change in pull request #11001:
URL: https://github.com/apache/arrow/pull/11001#discussion_r696697733
##########
File path: r/configure
##########
@@ -130,14 +130,8 @@ else
fi
else
# Set some default values/backwards compatibility
- if [ "${LIBARROW_DOWNLOAD}" = "" ] && [ "${NOT_CRAN}" != "" ]; then
- LIBARROW_DOWNLOAD=$NOT_CRAN; export LIBARROW_DOWNLOAD
- fi
- if [ "${LIBARROW_BINARY}" = "" ] && [ "${LIBARROW_DOWNLOAD}" != "" ];
then
- LIBARROW_BINARY=$LIBARROW_DOWNLOAD; export LIBARROW_BINARY
- fi
- if [ "${LIBARROW_MINIMAL}" = "" ] && [ "${LIBARROW_DOWNLOAD}" = "true"
]; then
- LIBARROW_MINIMAL=false; export LIBARROW_MINIMAL
+ if [ "${LIBARROW_BINARY}" = "" ] && [ "${NOT_CRAN}" = "true" ]; then
+ LIBARROW_BINARY=true; export LIBARROW_BINARY
fi
if [ "${LIBARROW_MINIMAL}" = "" ] && [ "${NOT_CRAN}" = "true" ]; then
LIBARROW_MINIMAL=false; export LIBARROW_MINIMAL
Review comment:
Let's simplify this a little further:
```suggestion
if [ "${NOT_CRAN}" = "true" ]; then
if [ "${LIBARROW_BINARY}" = "" ]; then
LIBARROW_BINARY=true; export LIBARROW_BINARY
fi
if [ "${LIBARROW_MINIMAL}" = "" ]; then
LIBARROW_MINIMAL=false; export LIBARROW_MINIMAL
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
