nealrichardson commented on a change in pull request #11001:
URL: https://github.com/apache/arrow/pull/11001#discussion_r696723923



##########
File path: r/inst/build_arrow_static.sh
##########
@@ -59,7 +59,7 @@ ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
     -DARROW_FILESYSTEM=ON \
     -DARROW_JEMALLOC=${ARROW_JEMALLOC:-$ARROW_DEFAULT_PARAM} \
     -DARROW_MIMALLOC=${ARROW_MIMALLOC:-ON} \
-    -DARROW_JSON=ON \
+    -DARROW_JSON=${ARROW_JSON:-ON} \

Review comment:
       Can we split this out to a separate JIRA? It's more involved than this 
because we'll have to conditionally build some of the bindings like we do with 
dataset and parquet, and we'll have to conditionally skip tests. See 
ARROW-11735 for a model.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to