nealrichardson commented on a change in pull request #11001:
URL: https://github.com/apache/arrow/pull/11001#discussion_r696808171
##########
File path: r/inst/build_arrow_static.sh
##########
@@ -59,7 +59,7 @@ ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
-DARROW_FILESYSTEM=ON \
-DARROW_JEMALLOC=${ARROW_JEMALLOC:-$ARROW_DEFAULT_PARAM} \
-DARROW_MIMALLOC=${ARROW_MIMALLOC:-ON} \
- -DARROW_JSON=ON \
+ -DARROW_JSON=${ARROW_JSON:-ON} \
Review comment:
Great, thanks. I'd revert here and do that change in ARROW-13768. If you
turn ARROW_JSON=OFF now, the build will fail (r/src/json.cpp won't compile). If
you want to do the full offline build test in this PR, will probably need to do
ARROW-13768 first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
