jorgecarleitao commented on pull request #982: URL: https://github.com/apache/arrow-datafusion/pull/982#issuecomment-914951098
My understanding of `cargo` is that libraries should not contain a `cargo.lock` in their git - only binaries should - https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries I did not place Python bindings as a member of the workspace because a workspace by definition [shares the `cargo.lock` across all its members](https://doc.rust-lang.org/book/ch14-03-cargo-workspaces.html#creating-a-workspace). So, I think the resolution here is to generate a `python/Cargo.lock` from the Python bindings alone, which maturin will use. This is also [how polars does it](https://github.com/pola-rs/polars/tree/master/py-polars). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
