alamb commented on pull request #982: URL: https://github.com/apache/arrow-datafusion/pull/982#issuecomment-916200027
FWIW we use `Cargo.lock` in IOx successfully (it works great!), though IOx is definitely an application rather than a library. Using Cargo.lock to avoid situations where upstream library changes break DataFusion CI like https://github.com/apache/arrow-datafusion/issues/968 sounds appealing, but then we may just be kicking the problems downstream (and farther from the root of the problem) to the users of DataFusion. What if we removed `datafusion-cli` and whatever crates create ballista binaries (`executor` and `core`)? out of the main workspace (aka remove them from `arrow-datafusion/Cargo.toml`)? Then we can have separate `Cargo.lock` for them but avoid adding Cargo.lock for the `datafusion` crate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
