Dandandan commented on pull request #982: URL: https://github.com/apache/arrow-datafusion/pull/982#issuecomment-914957434
Nice idea @houqp ! Some thoughts: One concern I have with using it for a library is that users of `datafusion` (as a library) will still update dependencies, and any build errors (with newer, failing dependencies) are not caught by having a fixed lock file (whereas we mostly get those errors in CI now in PRs if the build breaks based on incompatible dependencies). Next to that, do we have any users actually using the source release (e.g. with included Cargo.lock file), instead of only using `datafusion` in the Cargo.toml file? On the other hand, it still might have benefit if someone wants to do an (automated) build for distributing the binaries. But I am not sure if currently that's done somewhere? Also, before we go ahead with this, I think it makes sense to have a plan / document how to update the cargo lock file. Some options I can think of: * Manual/automated frequent update (e.g. weekly / bi-weekly) * Update on need * Automated, like dependabot (with a lot of dependencies, can cause quite some PR noise) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
