matthewmturner commented on a change in pull request #750:
URL: https://github.com/apache/arrow-rs/pull/750#discussion_r705662484
##########
File path: arrow/src/record_batch.rs
##########
@@ -419,6 +419,18 @@ impl From<&StructArray> for RecordBatch {
}
}
+impl PartialEq for RecordBatch {
+ fn eq(&self, other: &RecordBatch) -> bool {
+ let batches_equal = true;
Review comment:
Ok! I will update. I appreciate this type of feedback as im relatively
new to Rust, and still learning to write idiomatic Rust. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
