matthewmturner commented on pull request #750: URL: https://github.com/apache/arrow-rs/pull/750#issuecomment-916432884
Thx both - I will add check for column names. @jorgecarleitao regarding adding the `PartialEq` to `#derive()` - i had looked into this but saw the following in the docs (https://doc.rust-lang.org/std/cmp/trait.PartialEq.html): Specifically: "This trait can be used with #[derive]. When derived on structs, two instances are equal if all fields are equal, and not equal if any fields are not equal. When derived on enums, each variant is equal to itself and not equal to the other variants." I didnt think this would translate to the `RecordBatch` struct well - but tbh i didnt try. I can give it a shot though and see if it works. let me know if im misunderstanding anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
