matthewmturner commented on pull request #750: URL: https://github.com/apache/arrow-rs/pull/750#issuecomment-916913401
@nevi-me thank you for the feedback. I've added tests to cover the additional RecordBatch differences (col names, col numbers, row numbers). Also, i tried just adding `PartialEq` to `#derive()` as @jorgecarleitao suggested and it seems to have worked as all tests pass. So i dont think we need a custom implementation for `PartialEq` now. Let me know if this covers a good scope for this PR. If so, I can create a new issue to look into the point by @nevi-me on `RecordBatchOptions` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
