ianmcook commented on a change in pull request #11018:
URL: https://github.com/apache/arrow/pull/11018#discussion_r711135567
##########
File path: r/R/dplyr-summarize.R
##########
@@ -136,6 +136,17 @@ summarize_eval <- function(name, quosure, ctx, recurse =
FALSE) {
return()
}
+ if ("median" %in% funs_in_expr) {
+ expr <- wrap_median(expr)
Review comment:
Yep, my first instinct here was to use `extract_aggregations()` to do
this (since you're already recursing through the AST there), but that is only
called called when `any(inner_agg)`. I'll change it so it's also called in the
median case, and I'll do the AST insertion in there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
