ianmcook commented on a change in pull request #11018:
URL: https://github.com/apache/arrow/pull/11018#discussion_r713472484
##########
File path: r/tests/testthat/test-dplyr-summarize.R
##########
@@ -229,6 +229,60 @@ test_that("Group by n_distinct() on dataset", {
)
})
+test_that("median()", {
+ # with groups
+ expect_dplyr_equal(
+ input %>%
+ group_by(some_grouping) %>%
+ summarize(
+ med_dbl = median(dbl),
+ med_int = median(int),
+ med_dbl_narmf = median(dbl, FALSE),
+ # styler: off
+ med_int_narmf = median(int, na.rm = F),
Review comment:
At an earlier stage of this work I was mucking around with the NSE in
some even more exotic ways to try to get this all to work without ARROW-14050
or ARROW-14052. That introduced a sensitivity on the exact quoted value of
`na.rm`. I subsequently removed that, so this isn't needed any more. I removed
the `T` and `F` tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
