ianmcook commented on a change in pull request #11018:
URL: https://github.com/apache/arrow/pull/11018#discussion_r712645546
##########
File path: r/R/dplyr-summarize.R
##########
@@ -136,6 +136,17 @@ summarize_eval <- function(name, quosure, ctx, recurse =
FALSE) {
return()
}
+ if ("median" %in% funs_in_expr) {
+ expr <- wrap_median(expr)
Review comment:
@nealrichardson the code I needed to add inside `wrap_median()` and in
various other places here to deal with the `tdigest` and `hash_tdigest` kernel
output is unpleasant stuff. I think it's best to keep `wrap_median()`
self-contained instead of contaminating `extract_aggregations()` with it.
I think we should ask for pair of `appx_median` and `hash_appx_median`
kernels that wrap `tdigest(q = 0.5)` and `hash_tdigest(q = 0.5)`. That would
allow us to clean up this mess.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
