amol- commented on pull request #11185: URL: https://github.com/apache/arrow/pull/11185#issuecomment-922921240
> @amol- seems like there is cython logic supposed to handle the [conversion of different mask types to an ndarray](https://github.com/apache/arrow/blob/master/python/pyarrow/array.pxi#L2423), but only in the case if the [input is array like](https://github.com/apache/arrow/blob/master/python/pyarrow/array.pxi#L224). > > It would be nice if we could consolidate some of the logic, especially since we may remove the hard runtime numpy dependency in the future. That's a good point, I actually missed that when the first argument is a `numpy` array we go down a totally different code path into `numpy_to_arrow.cc`. That means that if you passed a `numpy.ndarray` as the first argument you would still be forced to use a `numpy` array for the mask too. I'll have to tweak `numpy_to_arrow.cc` too to deal with the situation where the array is a numpy one but the mask is not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
