amol- commented on pull request #11185: URL: https://github.com/apache/arrow/pull/11185#issuecomment-926459479
> > When a generic sequence is converted instead we accept numpy arrays, pyarrow arrays or plain sequences as the mask. > > I know the code is now already written, and we might want it in the future anyway, but as long as we don't accept pyarrow arrays for the values, I am not sure it makes sense from a user perspective to explicitly support pyarrow arrays for the mask .. > > (EDIT: but yes, so that was actually your original goal to add that, I remember now ..) Also note that even if I remove the optimized code path that deals with `BooleanArray` explicitly, arrow arrays still pass the `PySequence_Check` condition and thus would end up being traversed in any case. Given that the code that deals with `BooleanArray` is in the end very restricted, I think it makes sense to keep it around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
