jorisvandenbossche commented on pull request #11147: URL: https://github.com/apache/arrow/pull/11147#issuecomment-923887123
> When there is little ambiguity as to what a parameter means, there is no reason to make it keyword-only. > > @jorisvandenbossche Any thoughts on these changes? Yeah, we had a bit of discussion about it on Zulip, where the it was suggested to follow "required args -> positional, optional args -> keyword only", but so that clearly isn't a good rule, as I agree with your comments (so my initial "make a judgement call case by case based on whether you could understand it without the current" is better). > The FunctionOptions that were modified w.r.t. to positional/keyword-only args are: I think the changes listed at https://github.com/apache/arrow/pull/11147#issuecomment-922733817 all look good now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
