pitrou commented on a change in pull request #11147:
URL: https://github.com/apache/arrow/pull/11147#discussion_r712117470
##########
File path: python/pyarrow/tests/test_compute.py
##########
@@ -1921,9 +1937,9 @@ def validate_select_k(select_k_indices, tbl, sort_keys,
stable_sort=False):
with pytest.raises(ValueError, match="select_k_unstable requires "
"a non-empty `sort_keys`"):
- pc.select_k_unstable(table, k=2)
+ pc.select_k_unstable(table, k=2, sort_keys=[])
- with pytest.raises(ValueError, match="not a valid order"):
+ with pytest.raises(ValueError, match="not a valid 'sort order'"):
Review comment:
Nit, but the quotes around "sort order" look a bit gratuitous?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]