pitrou commented on a change in pull request #11147:
URL: https://github.com/apache/arrow/pull/11147#discussion_r712920339
##########
File path: python/pyarrow/_compute.pyx
##########
@@ -569,6 +543,10 @@ cdef class FunctionOptions(_Weakrefable):
return self.get_options().Equals(deref(other.get_options()))
+def _raise_invalid_function_option(value, description, *, error="keyword"):
Review comment:
This will give e.g.:
```"foo" is not a valid count mode keyword```
IMHO it would read better as:
```"foo" is not a valid count mode value```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
