augustoasilva commented on a change in pull request #11193:
URL: https://github.com/apache/arrow/pull/11193#discussion_r713832264
##########
File path: cpp/src/gandiva/filter.cc
##########
@@ -42,7 +43,7 @@ FilterCacheKey::FilterCacheKey(SchemaPtr schema,
expression_as_string_ = expression.ToString();
UpdateUniqifier(expression_as_string_);
arrow::internal::hash_combine(result, expression_as_string_);
- arrow::internal::hash_combine(result, configuration);
+ arrow::internal::hash_combine(result, configuration->Hash());
Review comment:
I thought that configuration being a shared_ptr when using it directly
to hash it hashed the memory location value, so as it has a Hash() function, it
looked better to use the hash_code that it generates to use on the
hash_combine.
Do you think it is better to undo this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
