augustoasilva commented on a change in pull request #11193:
URL: https://github.com/apache/arrow/pull/11193#discussion_r713844650
##########
File path: cpp/src/gandiva/llvm_generator.h
##########
@@ -49,10 +51,48 @@ class GANDIVA_EXPORT LLVMGenerator {
static Status Make(std::shared_ptr<Configuration> config,
std::unique_ptr<LLVMGenerator>* llvm_generator);
+ static std::shared_ptr<Cache<BaseCacheKey,
std::shared_ptr<llvm::MemoryBuffer>>>
+ GetCache();
+
/// \brief Build the code for the expression trees for default mode. Each
/// element in the vector represents an expression tree
Status Build(const ExpressionVector& exprs, SelectionVector::Mode mode);
+ /// \brief Build the code for the expression trees for default mode with a
LLVM
+ /// ObjectCache. Each element in the vector represents an expression tree
+ template <class KeyType>
+ Status Build(const ExpressionVector& exprs, SelectionVector::Mode mode,
Review comment:
I know, but because this uses template, if it is on the cc file this
function gets an undefined reference error for it, as just this function is
using template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
