augustoasilva commented on a change in pull request #11193:
URL: https://github.com/apache/arrow/pull/11193#discussion_r713840682
##########
File path: cpp/src/gandiva/llvm_generator.cc
##########
@@ -50,6 +51,23 @@ Status LLVMGenerator::Make(std::shared_ptr<Configuration>
config,
return Status::OK();
}
+std::shared_ptr<Cache<BaseCacheKey, std::shared_ptr<llvm::MemoryBuffer>>>
+LLVMGenerator::GetCache() {
+ static Cache<BaseCacheKey, std::shared_ptr<llvm::MemoryBuffer>> cache;
+ // static std::unique_ptr<Cache<BaseCacheKey,
std::shared_ptr<llvm::MemoryBuffer>>>
+ // cache_unique = std::make_unique<Cache<BaseCacheKey,
+ // std::shared_ptr<llvm::MemoryBuffer>>>();
+
+ // static std::shared_ptr<Cache<BaseCacheKey,
std::shared_ptr<llvm::MemoryBuffer>>>
+ // shared_cache = std::move(cache_unique);
Review comment:
Removed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
