jonkeane commented on pull request #11225: URL: https://github.com/apache/arrow/pull/11225#issuecomment-930177590
> @jonkeane oh I see. It's only the levels attribute that is an altrep. This is nice, but I'm sure we can (in a follow up pull request) also make the integer vector an altrep: https://issues.apache.org/jira/browse/ARROW-14169 Yeah, I've already [made a PR to {arrowbench}](https://github.com/ursacomputing/arrowbench/pull/40) to fix this using your suggestion and it does now successfully catch that the factors themselves are not altrep. It is kinda cool that this all _just worked_ with the levels vector — I wouldn't have expected that (and it's not a _huge_ deal or hugely helpful, though I guess it could be for factors with super large string levels?) but cool that it _just worked_. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
